The Ou Case

From Apache OpenOffice Wiki
< Calc‎ | Performance
Revision as of 15:20, 6 March 2009 by ErAck (Talk | contribs)

Jump to: navigation, search


Loading a large plain data file takes very long.

References:

Findings:

  • source/filter/xml/xmlsubti.cxx
    • 38% of time spent in ScMyTables::NewColumn() because of replicated use of aTableVec[nTableCount - 1] (vector::operator[])
      Note: percentage may be off due to compilation without optimization to obtain exact line numbers that may result in STLport's vector methods being differently compiled.
      • proposed fix: should obtain the pointer once instead.
    • Similar for other places where aTableVec[xxx] is used.
  • TODO: Check all ScMyTables::.*() and ScMyTableData::.*()
    • Especially for 63342857 calls to AddColumn() and NewColumn() that result in 1168654944 calls to operator[] ...
    • 63081776 calls to AddColumn() originate from ScXMLTableRowCellContext::EndElement()
    • Those are highly suspicious and seem to indicate that too many temporary elements are created for empty columns/cells (needs verification).
Retrieved from "https://wiki.openoffice.org/w/index.php?title=Calc/Performance/The_Ou_case&oldid=114950"
Personal tools